-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests to correct folder #61
Conversation
Damn, that's too bad :( |
Moving to Kotlin 1.6.0 fixes the issue for me. I'm also going to attempt to use the workaround, since this is internal anyway. |
@lenguyenthanh this is the fix following the tickets on the trackers. @Serializable(with = ReferencedSerializer::class)
public open class Referenced<out A> internal constructor() {
public data class Ref(public val value: Reference) : Referenced<Nothing>()
public data class Other<A>(val value: A) : Referenced<A>()
public fun <B> map(f: (A) -> B): Referenced<B> =
when (this) {
is Other -> Other(f(value))
is Ref -> this
else -> TODO("Impossible.")
}
} Test locally, and in downstream project and it fixes the issue for me. |
Great thanks @nomisRev ! I will try it local and push it to this branch. |
It worked locally, and |
According to YouTrack this should be fixed in Kotlin 1.6.20, which is currently in M1. Off-topic@lenguyenthanh Are you depending on the SNAPSHOT? I also found they have an incorrect name. "io.arrow-kt:ktor-server:0.1.2-SNAPSHOT"
"io.arrow-kt:openapi-docs:0.1.2-SNAPSHOT" instead of "io.arrow-kt:arrow-endpoint-ktor-server:0.1.2-SNAPSHOT"
"io.arrow-kt:arrow-endpoint-openapi-docs:0.1.2-SNAPSHOT" |
Thanks for reporting and helping looking into this @lenguyenthanh ❤️ |
Yeah, I agree with your approach, no need to rush to merge this PR. I'm still using my Jitpack version. But I will try to use the snapshot version soon. Thanks for the head up, @nomisRev ! |
Close due to inactivity :( |
I think we moved this test file into a wrong folder, so it stops running ( that why we thought it passes). But it is actually still failed.