Fix Either deprecation replacement expressions
#2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gutiory
changed the title
Either deprecation replacement expressionEither deprecation replacement expressions
Kover Report
|
franciscodr
reviewed
Mar 10, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt
Outdated
Show resolved
Hide resolved
…ther.kt Co-authored-by: Francisco Diaz <[email protected]>
nomisRev
reviewed
Mar 10, 2023
Comment on lines
2296
to
2297
| RedundantAPI + "Prefer zipOrAccumulate", | ||
| ReplaceWith("Either.zipOrAccumulate({ a, bb -> SGA.run { a.combine(bb) } }, this, b) { a, bb -> SGB.run { a.combine(bb) } }") | ||
| ReplaceWith("Either.zipOrAccumulate<A, B, B, B>({ a:A, bb:A -> a.plus(bb) }, this, b) { a:B, bb:B -> a.plus(bb) }") |
There was a problem hiding this comment.
question: Was the SGA.run { a.combine(bb) } here broken? If yes, then I think this is an improvement but we should probably just use a + b instead of a.plus(b) or is that also broken? 😅
Perhaps we should also add in the description that for custom types, plus needs to be replaced with a custom combine function?
There was a problem hiding this comment.
+ works fine! Thanks @nomisRev . See 6332005 (#2973)
i-walker
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the deprecation
ReplaceWithsuggestions forEitherlisted in #2964. I'll update the issue table once this is merged.