Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Result zip method in favour of DSL #2977

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

gutiory
Copy link
Collaborator

@gutiory gutiory commented Mar 13, 2023

This PR implements the issue #2970

A test case has been added to check the replacement suggested in the Deprecation annotation works.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023

Kover Report

File Coverage [41.53%]
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Result.kt 41.53%
Total Project Coverage 42.86%

@gutiory gutiory force-pushed the jg-deprecate-result-zip branch from c8573d2 to 3f24ce3 Compare March 13, 2023 15:45
Copy link
Member

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arrow-kt arrow-kt deleted a comment from rafaparadela Mar 16, 2023
gutiory added 2 commits March 16, 2023 13:11
This test does no make sense. Both methods do no return the same value.
@gutiory gutiory force-pushed the jg-deprecate-result-zip branch from d9b8fe3 to 8e6687c Compare March 16, 2023 12:20
@gutiory gutiory requested a review from nomisRev March 16, 2023 12:20
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me @gutiory! Thank you so much ☺️

@gutiory gutiory merged commit ff54c74 into main Mar 16, 2023
@franciscodr franciscodr deleted the jg-deprecate-result-zip branch March 16, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants