Change: address #34 by updating combine*'s API #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34 by addressing the issue there for all
combine*
functions.The tl;dr is that the data needs to be sent, by itself, as the last function call, similarly to how
converge
andjuxt
work in ramda.You can call
combineWith
andcombineWithP
like(f)(g)(a)
or(f, g)(a)
, but not(f, g, a)
nor(f)(g, a)
.IMO, this constitutes a breaking change and is a major version bump unless y'all can somehow justify it as a bug fix.
Let me know what y'all think and what changes you want to see!