Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: address #34 by updating combine*'s API #40

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

rpearce
Copy link
Contributor

@rpearce rpearce commented Nov 4, 2021

Closes #34 by addressing the issue there for all combine* functions.

The tl;dr is that the data needs to be sent, by itself, as the last function call, similarly to how converge and juxt work in ramda.

You can call combineWith and combineWithP like (f)(g)(a) or (f, g)(a), but not (f, g, a) nor (f)(g, a).

IMO, this constitutes a breaking change and is a major version bump unless y'all can somehow justify it as a bug fix.

Let me know what y'all think and what changes you want to see!

@rpearce rpearce self-assigned this Nov 4, 2021
@mgreystone
Copy link
Member

I think useWithP also has this problem. I'd doublecheck all the assemble*'s too, though a quick glance makes me think that it might be fine.

These look perfect to me.

@rpearce
Copy link
Contributor Author

rpearce commented Nov 4, 2021

useWithP and assemble* all look 👍 to me

@mgreystone
Copy link
Member

We'll need to make it clear this is a breaking change (on purpose this time).

@rpearce
Copy link
Contributor Author

rpearce commented Nov 4, 2021

I don't see a CHANGELOG.md for us, and there is only 1 release.

I can do a GH release and write up the info there for this latest version once this is merged.

@rpearce
Copy link
Contributor Author

rpearce commented Nov 4, 2021

I'd like to wait for another ✅ before merging. @mgreystone is there anyone else that you think we should request review from who would be interested?

@mgreystone
Copy link
Member

mgreystone commented Nov 4, 2021

I believe rise.com is the largest consumer of funky. cc @jasminabasurita @JWA111

@rpearce
Copy link
Contributor Author

rpearce commented Nov 5, 2021

Going to merge this on Monday and publish a major version then.

@rpearce
Copy link
Contributor Author

rpearce commented Nov 8, 2021

No additional feedback. Merging.

@rpearce rpearce merged commit 94226e6 into master Nov 8, 2021
@rpearce rpearce deleted the change/combineall branch November 8, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Curried Function Lengths Are Wrong
2 participants