ci(actions): migrate to GitHub Actions #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloberg
force-pushed
the
feature/github-actions
branch
from
727dcf0 to
49eab75
Compare
Remove Travis config. Remove coveralls npm package and use action instead
mloberg
force-pushed
the
feature/github-actions
branch
from
49eab75 to
087684d
Compare
rpearce
approved these changes
Aug 23, 2022
tylerthehaas
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be using Travis anymore. Setup a workflow to run tests against Node 12, 14, and 16.
Dropped the coveralls npm package in favor of the action. As part of this work, I had to rework how coverage was being generated. The
test:coveragescript wasn't working, but calling nyc via npx is working. This way you could also generate the required lcov file with one script. If we want to be able to show coverage locally, we should talk about solutions as calling nyc from yarn doesn't seem to be working.