Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ramda to v0.27.2 #42

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Upgrade ramda to v0.27.2 #42

merged 1 commit into from
Feb 8, 2023

Conversation

PurrBiscuit
Copy link
Contributor

@PurrBiscuit PurrBiscuit commented Feb 6, 2023

We need to upgrade ramda in revocal, and its dependency funky, as part of a security alert from Snyk (linked in the issue below). We need to ugrade to version 0.27.2 or higher for ramda. We can't use 0.28.0 in funky yet because we still depend on the composeP function (among some others) that was removed from version 0.28.0 of ramda.

Issue: https://github.com/articulate/identity/issues/924

@PurrBiscuit
Copy link
Contributor Author

@mgreystone I vaguely remember there was some issue around updating ramda in funky before but I can't seem to find any mentions of it in Slack or on the issues on this package. Do you know if this is safe to upgrade ramda on yet?

@mgreystone
Copy link
Member

@PurrBiscuit I cannot think of any reason not to upgrade ramda.

@PurrBiscuit
Copy link
Contributor Author

I must be thinking of something else...maybe it was upgrading funky in rise-platform-frontend and there being an issue with that.

@PurrBiscuit PurrBiscuit requested a review from a team February 6, 2023 22:58
Copy link

@lucasadrianof lucasadrianof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

image

@PurrBiscuit PurrBiscuit merged commit 38d4b48 into main Feb 8, 2023
@PurrBiscuit PurrBiscuit deleted the upgrade-ramda branch February 8, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants