Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript .d.ts (v1) #49

Merged
merged 52 commits into from
Jan 16, 2024
Merged

Typescript .d.ts (v1) #49

merged 52 commits into from
Jan 16, 2024

Conversation

mgreystone
Copy link
Member

@mgreystone mgreystone commented Jan 8, 2024

Add typescript .d.ts definitions to v1. v2 is incoming.

Use tsd for testing type definitions. Port the existing unit tests to type tests. As such, some of the tests are a bit ridiculous, but they will evolve over time.

This is a starting point. This will not be perfect but will give us a common framework for moving forward.

Copy link

@toristyner toristyner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you generate the type def files? manually? Ive been using github copilot and its pretty good at inferring types

@mgreystone
Copy link
Member Author

I did it manually. I asked ChatGPT for help with assemble, but it gave me completely wrong answers. Will try copilot next time.

@mgreystone mgreystone merged commit 882f8b3 into v1 Jan 16, 2024
@mgreystone mgreystone deleted the ts-v1 branch January 16, 2024 19:46
@mgreystone mgreystone mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants