@damassi => Upgrades typescript and enables type emitting

[l2succes]

This allows us to emit type definitions alongside compiled js files in our reaction builds so consumers that also use typescript (e.g. 'force') have access to them.

TODO

• swap build from babel 7 back to tsc

[damassi]

One thing we should try to do if possible is use a root directory similar to here so that we don't have to define individual keys.

[damassi]

@l2succes - @zephraph pointed out that the reason decorators might be breaking with babel is because the legacy option might not be set. Can you try setting this in our babel config and see if switching from typescript-babel-jest to babel-jest fixes everything and all tests run?

[damassi]

Would moving this under `typeRoots be better? Like

"typeRoots": [
    "node_modules/@types",
    "node_modules/styled-components/typings/styled-components.d.ts"
  ]

(not sure)

[l2succes]

Right, I removed that line as it was just an experiment to fix TS errors

[l2succes]

@damassi I can look into it but switching to ts-jest worked great.

I go through all of the type errors and verified .d.ts files are generating properly both with yarn compile and yarn watch

[damassi]

@l2succes - all good, was just curious if it compiled without errors, but nbd 👍

[damassi]

@l2succes - I wonder if there is some way we could ignore imported interfaces without having to flag each unused import -- do you know if there is a TSLint / ts config option that would allow us to keep this clean?

Also, i'm pretty sure this is a shot in the dark, but any way to auto-export interfaces?

@orta / @alloy - have y'all ever come across a good way to do this?

[l2succes]

@damassi unfortunately, I don't think there's a way to ignore a whole block 😔 (Related: microsoft/TypeScript#19573)

They just fixed the main issue that enables us to emit types in the first place with [email protected] since this issue is related I think they should give us a way to auto-import interfaces when generating types

[damassi]

Ahh cool cool, so I imagine we'll just have to track this as the feature becomes more mature 👍

[alloy]

Why are references being imported and then ignored?

[damassi]

@alloy - in order for the types to be automatically emitted, it needs an in-scope reference to the interface -- in the example above, LinkProps needs to be made available BUT because we're not using it directly in the code (only during the compilation process) it needs to be ignored due to the noUnusedLocals setting.

This aspect of type emission kinda bugs me because it clutters up code with some developer vs compiler indirection, but I suspect now that this feature has landed there will be some overall tooling improvements coming soon that will help clean the process up.

[l2succes]

@artsy/engineering

We just upgraded typescript to 2.9 which allows us to enable emitting types for reaction. What that means is you'll see some new errors if you don't make certain things public. Some changes,
for any new components you work on, you'll need to export the Props interface associated with the component. For example:

export interface IconProps {
  name: string;
}

const Icon: React.SFC<IconProps> = props => {
  ...
}

[damassi]

@l2succes - Can you update README with some info on type emission and notify #dev since errors due to non-exported types could be confusing?