Fix PHP 8.2 warnings, add PHPStan, refactor type hinting, and fix notification link and content #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, I found that the following conditional block was causing problems:
This block was modifying the $subject and $subjectModel variables unnecessarily. The correct implementation was already present before this block:
So, I've removed the problematic conditional block entirely, which resolved the issue.
I have tested the push notifications with new posts and with
fof/byobu
. Everything is working as expected, with no errors or issues found.