API changes to hosting and TestServer #521
Conversation
davidfowl
changed the title
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| IApplicationLifetime Lifetime { get; } |
There was a problem hiding this comment.
IApplicationLifetime, IHostingEnvironment, ILoggerFactory seem pretty weird to require here. They're all in services.
There was a problem hiding this comment.
They are services that are created by the Builder but you're right, it might be weird. But they are so commonly used.
There was a problem hiding this comment.
You don't have a lot of implementations to base that on. Right now they're only used in Run.
|
@davidfowl are you going to finish this or is @JunTaoLuo supposed to take over? |
| /// Retruns the server addresses the web application is going to listen on. | ||
| /// </summary> | ||
| /// <param name="application"></param> | ||
| /// <returns></returns> |
|
@JunTaoLuo will need to take over. I'd like to get this in this week. I wanted to flesh out the API enough to see if it feels good. I'm going to make the review changes and rebase |
davidfowl
force-pushed
the
davidfowl/hosting-api-changes
branch
from
da55861 to
ab5de9b
Compare
|
API looks much nicer! looks good to me |
| @@ -7,7 +7,13 @@ public class Program | |||
| { | |||
| public static void Main(string[] args) | |||
There was a problem hiding this comment.
Are we removing Program.Main yet?
There was a problem hiding this comment.
I did, just forgot to update this PR.
| @@ -9,7 +9,6 @@ | |||
| using System.Threading.Tasks; | |||
There was a problem hiding this comment.
Rename the class, file, and tests.
|
@JunTaoLuo @Tratcher another change we should make. We should disable the automatic detection of startup based on assembly if nothing was specified. The API should just make you specify it and our template should be explicit as well. |
|
@davidfowl What do you mean by automatic detection? Do you mean ApplicationName from PlatformHandlers, Configuration, StartupAssemblyName or all of them?https://github.com/aspnet/Hosting/blob/dev/src/Microsoft.AspNet.Hosting/WebHostBuilder.cs#L132 |
JunTaoLuo
force-pushed
the
davidfowl/hosting-api-changes
branch
from
b36e74f to
c7f998a
Compare
|
Just application name. The others are explicit |
JunTaoLuo
force-pushed
the
davidfowl/hosting-api-changes
branch
from
c7f998a to
1c70ff4
Compare
Please take a look
/cc @JunTaoLuo @Tratcher @DamianEdwards @lodejard @HaoK @rynowak