Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

React to pipeline changes #1250

Merged
merged 6 commits into from
Jan 4, 2018
Merged

React to pipeline changes #1250

merged 6 commits into from
Jan 4, 2018

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Dec 22, 2017

No description provided.

@pakrym pakrym requested a review from BrennanConroy December 22, 2017 19:06
@pakrym pakrym changed the title React to pipeline changes [WIP] React to pipeline changes Dec 22, 2017
@@ -7,6 +7,8 @@
$(RestoreSources);
https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json;
https://dotnet.myget.org/F/aspnetcore-tools/api/v3/index.json;
https://dotnet.myget.org/F/dotnet-core/api/v3/index.json;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natemcmaster FYI in case you have an alternative.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's temporary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for local builds and temporary workarounds, but would break in Universe if you don't also update that to pull the new corefxlab packages.

Copy link
Contributor

@analogrelay analogrelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a product-code perspective. Need to rebase and resolve conflicts. Also, deal with the package sources as per Nate's comment.

@pakrym pakrym force-pushed the pakrym/react-to-pipelines-again branch from 21aab4b to 0ef8ba9 Compare January 3, 2018 19:10
@pakrym pakrym changed the title [WIP] React to pipeline changes React to pipeline changes Jan 4, 2018
@pakrym pakrym merged commit 8a4adf1 into dev Jan 4, 2018
@BrennanConroy BrennanConroy deleted the pakrym/react-to-pipelines-again branch January 19, 2018 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants