Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add circleci support #31

Merged
merged 3 commits into from
Jun 27, 2018
Merged

Feature/add circleci support #31

merged 3 commits into from
Jun 27, 2018

Conversation

ThomasRoehl
Copy link

Summary

This PR solves #27

Other Information

We want to go for circleci.

@ThomasRoehl
Feature/publish docker image (#30)
a18ef80 
* add publish docker job to circleci config
@ghost ghost assigned ThomasRoehl Jun 27, 2018
@ghost ghost added the progress:working label Jun 27, 2018
@mrsimpson mrsimpson self-requested a review June 27, 2018 09:08
mrsimpson
mrsimpson approved these changes Jun 27, 2018
View reviewed changes
Copy link
Member

@mrsimpson mrsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Image built
  • Image tagged and pushed properly
  • NLP libs are being downloaded during startup

=> go

@mrsimpson mrsimpson merged commit a17a239 into develop Jun 27, 2018
@ghost ghost removed the progress:working label Jun 27, 2018
@ruKurz ruKurz deleted the feature/add-circleci-support branch March 1, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsimpson mrsimpson mrsimpson approved these changes

Assignees

@ThomasRoehl ThomasRoehl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasRoehl @mrsimpson