-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): bridge sudo change command #1612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5543fa
to
3fe2ef2
Compare
sambukowski
requested changes
Oct 9, 2024
992f368
to
a84f9ec
Compare
sambukowski
approved these changes
Oct 16, 2024
a84f9ec
to
c08bcda
Compare
Fraser999
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick, otherwise LGTM.
println!(" Rollup Id: {}", info.rollup_id); | ||
println!(" Asset: {}", info.asset); | ||
println!(" Sudo Address: {}", info.sudo_address); | ||
println!(" Withdrawer Address {}", info.withdrawer_address); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
println!(" Withdrawer Address {}", info.withdrawer_address); | |
println!(" Withdrawer Address: {}", info.withdrawer_address); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds bridge-sudo-change command for changing bridge privileges addresses
Background
Part of adding more actions to the cli
Changes
bridge-sudo-change
command setting bridge account privileges addressesbridge-account get
command querying bridge account informationTesting
Locally against a cluster
Related Issues
Part of #1474
closes #1547