Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): bridge sudo change command #1612

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

quasystaty1
Copy link
Contributor

@quasystaty1 quasystaty1 commented Oct 2, 2024

Summary
Adds bridge-sudo-change command for changing bridge privileges addresses

Background
Part of adding more actions to the cli

Changes

  • adds bridge-sudo-change command setting bridge account privileges addresses
  • adds bridge-account get command querying bridge account information
    Testing
    Locally against a cluster

Related Issues
Part of #1474

closes #1547

@quasystaty1 quasystaty1 requested review from a team as code owners October 2, 2024 17:39
@github-actions github-actions bot added the cd label Oct 2, 2024
@quasystaty1 quasystaty1 force-pushed the quasystaty1/ENG-835/cli/bridge-sudo-change branch from d5543fa to 3fe2ef2 Compare October 2, 2024 18:45
@quasystaty1 quasystaty1 force-pushed the quasystaty1/ENG-835/cli/bridge-sudo-change branch from 992f368 to a84f9ec Compare October 16, 2024 12:08
@sambukowski sambukowski added the cli pertaining to the cli label Oct 17, 2024
@quasystaty1 quasystaty1 force-pushed the quasystaty1/ENG-835/cli/bridge-sudo-change branch from a84f9ec to c08bcda Compare October 24, 2024 14:01
Copy link
Contributor

@Fraser999 Fraser999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise LGTM.

println!(" Rollup Id: {}", info.rollup_id);
println!(" Asset: {}", info.asset);
println!(" Sudo Address: {}", info.sudo_address);
println!(" Withdrawer Address {}", info.withdrawer_address);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
println!(" Withdrawer Address {}", info.withdrawer_address);
println!(" Withdrawer Address: {}", info.withdrawer_address);

@quasystaty1 quasystaty1 added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@quasystaty1 quasystaty1 added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 1a69dc8 Nov 6, 2024
46 checks passed
@quasystaty1 quasystaty1 deleted the quasystaty1/ENG-835/cli/bridge-sudo-change branch November 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cd cli pertaining to the cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cli): add BridgeSudoChange command
3 participants