feat: implement new genesis endpoint #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperFluffy
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
In general this looks good, except that this change carries a typo forward ("dequencer") and that I think the omitempty has on the base heights has the wrong semantics. Also I think I would like to emphasize celestia here (over data availability) similar to what we did in conductor.
| func (s *ExecutionServiceServerV1Alpha2) GetGenesisInfo(ctx context.Context, req *astriaPb.GetGenesisInfoRequest) (*astriaPb.GenesisInfo, error) { | ||
| log.Info("GetGenesisInfo called", "request", req) | ||
|
|
||
| rollupId := sha256.Sum256([]byte(s.bc.Config().AstriaRollupName)) |
There was a problem hiding this comment.
nit: Inject the ID into the config as part of startup instead of calculating it ad hoc? No hard opinion on that tho.
There was a problem hiding this comment.
I think this is the best way to do this without messing with how configs get parsed and such in geth. As many changes kept to this file is better. Especially since this is called once on startup, not a high computation cost.
joroshiba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to support the new execution API endpoint
GetGenesisInfoand additionally adds some metrics: