Fix gdrive_to_snowflake task in example_load_dag #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200 and
pankajastro
as code owners
pankajastro
approved these changes
Dec 22, 2023
| @@ -23,7 +23,7 @@ function echo_help() { | |||
| echo "ASTRO_ORGANIZATION_ID Astro cloud organization Id" | |||
| echo "ASTRO_DEPLOYMENT_ID Astro cloud Deployment id" | |||
| echo "TOKEN Astro workspace token" | |||
| echo "bash deploy.sh <ASTRO_DOCKER_REGISTRY> <ASTRO_ORGANIZATION_ID> <ASTRO_DEPLOYMENT_ID> <TOKEN>" | |||
| echo "bash deploy.sh <ASTRO_DOCKER_REGISTRY> <ASTRO_ORGANIZATION_ID> <ASTRO_DEPLOYMENT_ID> <TOKEN> " | |||
There was a problem hiding this comment.
Suggested change
| echo "bash deploy.sh <ASTRO_DOCKER_REGISTRY> <ASTRO_ORGANIZATION_ID> <ASTRO_DEPLOYMENT_ID> <TOKEN> " | |
| echo "bash deploy.sh <ASTRO_DOCKER_REGISTRY> <ASTRO_ORGANIZATION_ID> <ASTRO_DEPLOYMENT_ID> <TOKEN>" |
?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
==========================================
+ Coverage 89.54% 90.12% +0.57%
==========================================
Files 75 75
Lines 4323 4323
Branches 537 538 +1
==========================================
+ Hits 3871 3896 +25
+ Misses 355 327 -28
- Partials 97 100 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gdrive_to_snowflaketask was failing because we hadn't set theGOOGLE_APPLICATION_CREDENTIALSin deployment. This pull request addresses the issue by creating a credential file using the Google Cloud Platform Service Account credentials from secrets, which is essential for the task.