⚡invert check order in onlyOperatorOrOwner()

asymmetryfinance · May 13, 2024 · 390d52e · 390d52e
1 parent 24d810b
commit 390d52e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/AfCvx.sol b/src/AfCvx.sol
@@ -42,12 +42,10 @@ contract AfCvx is IAfCvx, TrackedAllowances, Ownable, ERC4626Upgradeable, ERC20P
     uint16 public weeklyWithdrawalShareBps;
 
     modifier onlyOperatorOrOwner() {
-        if (msg.sender != owner()) {
-            if (msg.sender != operator) {
-                revert Unauthorized();
-            } else if (paused) {
-                revert Paused();
-            }
+        if (msg.sender != operator) {
+            if (msg.sender != owner()) revert Unauthorized();
+        } else if (paused) {
+            revert Paused();
         }
         _;
     }

diff --git a/src/strategies/CLeverCVXStrategy.sol b/src/strategies/CLeverCVXStrategy.sol
@@ -43,12 +43,10 @@ contract CleverCvxStrategy is ICleverCvxStrategy, TrackedAllowances, Ownable, UU
     }
 
     modifier onlyOperatorOrOwner() {
-        if (msg.sender != owner()) {
-            if (msg.sender != operator) {
-                revert Unauthorized();
-            } else if (paused) {
-                revert Paused();
-            }
+        if (msg.sender != operator) {
+            if (msg.sender != owner()) revert Unauthorized();
+        } else if (paused) {
+            revert Paused();
         }
         _;
     }