🪲 [M-3] fix potential overflow in maxTotalUnlock()

asymmetryfinance · May 12, 2024 · 423ed33 · 423ed33
1 parent 6483713
commit 423ed33
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/src/strategies/CLeverCVXStrategy.sol b/src/strategies/CLeverCVXStrategy.sol
@@ -269,9 +269,18 @@ contract CleverCvxStrategy is ICleverCvxStrategy, TrackedAllowances, Ownable, UU
         uint256 repayAmount = clevCvxAvailable.mulDiv(CLEVER_FEE_PRECISION, CLEVER_FEE_PRECISION + repayRate);
 
         (uint256 totalDeposited,,, uint256 totalBorrowed,) = CLEVER_CVX_LOCKER.getUserInfo(address(this));
-        // decrease borrowed amount
-        totalBorrowed -= repayAmount;
-        maxUnlock = totalDeposited - totalBorrowed.mulDiv(CLEVER_FEE_PRECISION, reserveRate);
+
+        if (totalBorrowed > repayAmount) {
+            // Decrease borrowed amount
+            unchecked {
+                totalBorrowed = totalBorrowed - repayAmount;
+            }
+            maxUnlock = totalDeposited - totalBorrowed.mulDiv(CLEVER_FEE_PRECISION, reserveRate);
+        } else {
+            // Amount of clevCVX in Furnace can be greater than the borrowed amount only if
+            // CVX is swapped for clevCVX and deposited to Furnace, rather than locked in CleverLocker.
+            maxUnlock = totalDeposited;
+        }
 
         if (maxUnlock > unlockObligations) {
             unchecked {