ADM-914:[backend][frontend] feat: set file name with time range when generate file #1386
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesThe deprecated coverage status is not being sent today as part of the scheduled brownout. Know more |
|
Hi @yulongcai! 👋 |
| .csvTimeStamp("1720000000000") | ||
| .startTime("1710000000000") | ||
| .endTime("1712678399999") |
There was a problem hiding this comment.
convert 1720000000000 all those value into a readable variable
| } | ||
|
|
||
| @Nested | ||
| class GenerateReportByType { | ||
|
|
||
| String timeStamp = "1683734399999"; | ||
|
|
||
| String startTimeStamp = "1710000000000"; |
| InputStreamResource result = reportService.exportCsv(reportType, Long.parseLong(filename)); | ||
| log.info("Successfully get CSV file_reportType: {}, filename: {}, _result: {}", reportType.getValue(), filename, | ||
| result); | ||
| @PathVariable String timeStamp, @Parameter String startDate, @Parameter String endDate) { |
There was a problem hiding this comment.
put those 2 new variables into the API path
| params: { | ||
| startDate: this.parseCollectionDateToHumanDate(params.startDate), | ||
| endDate: this.parseCollectionDateToHumanDate(params.endDate), | ||
| }, |
There was a problem hiding this comment.
fix with the API scheme
| @@ -9,7 +9,13 @@ export class CSVClient extends HttpClient { | |||
|
|
|||
| exportCSVData = async (params: CSVReportRequestDTO) => { | |||
| await this.axiosInstance | |||
| .get(`/reports/${params.dataType}/${params.csvTimeStamp}`, { responseType: 'blob' }) | |||
| .get(`/reports/${params.dataType}/${params.csvTimeStamp}`, { | |||
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
backend/src/main/java/heartbeat/service/report/CSVFileGenerator.java
Fixed
Show resolved
Hide resolved
|
下午两个团队一起diff一哈 |
|
|
Summary
set file name with time range when generate file
Before
After
Note
Null