ADM-928 [frontend]: fix dc issues and implement the retry function #1441
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
|
Hi @Leiqiuhong! 👋 |
|
|
| boardInfoError?: boolean; | ||
| pipelineInfoError?: boolean; | ||
| pipelineStepError?: boolean; |
There was a problem hiding this comment.
is/hasBoardInfoError......
why it is ?? the default value is true or false when not give the specific value when implamentation
There was a problem hiding this comment.
There is something really wrong with the name. But the value needs to be '?', so that the subsequent assignment will be more convenient
| const stepNumber = useAppSelector(selectStepNumber); | ||
| const backgroundColor = stepNumber === 1 ? theme.palette.secondary.dark : theme.palette.common.white; |
There was a problem hiding this comment.
1 what does it mean?
give it a meaningful name, and refactor the belowe one
Summary
ADM-928 [frontend]: fix dc issues and implement the retry function
Before
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
After
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
Note
Null