Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1560] Allow issuer as url #523

Merged
merged 4 commits into from
Jul 20, 2020
Merged

[SDK-1560] Allow issuer as url #523

merged 4 commits into from
Jul 20, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Jul 13, 2020 •
edited
Loading

Description

Allow issuer option to be passed a fully qualified url

References

See #428
https://tools.ietf.org/id/draft-ietf-oauth-discovery-08.html#ASMetadata

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added small CH: Added PR is adding feature or functionality labels Jul 13, 2020
@adamjmcgrath adamjmcgrath added this to the vNext milestone Jul 13, 2020
@adamjmcgrath adamjmcgrath requested a review from a team July 13, 2020 10:13
stevehobbsdev
stevehobbsdev previously approved these changes Jul 13, 2020
View reviewed changes
@adamjmcgrath adamjmcgrath merged commit 3fa28c3 into master Jul 20, 2020
@stevehobbsdev stevehobbsdev deleted the issuer-url branch October 30, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Added PR is adding feature or functionality
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @stevehobbsdev