[SDK-3583] Do not throw from checkSession #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov has noticed a decrease of 0.01% in coverage because we removed code. We should be fine ignoring that. |
ewanharris
approved these changes
Aug 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Our SDK has a set of recoverable errors it swallows, the other errors are surfaced to the user. This has caused some confusion before, and as checkSession is a silent wrapper around getTokenSilently to see if a user can be obtained to initialize the SDK, it should swallow any exceptions. Any error probably indicates there is no user, and the SDK should behave as such. Once the user calls any of the other SDK methods (e.g. loginWithRedirect or getTokenSilently), it should surface the exact same error that was swallowed by checkSession.
Checklist