-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.9.0 build doesn't include src/javascript/index.js in release #29
Comments
Dunno how I missed this issue when you first filed it...a year and a half ago...but uh sorry!! Will fix! |
* Run 'npm update --save' on repo * Attempt a fix for the problem described in #29 * Use more recent node versions in GitHub CI/CD workflow
Version 0.9.1—which I just released on NPM and here on GitHub—should fix this issue I think, but please take a look and let me know if this is working correctly for you. |
There's also v0.9.2 available now. I didn't think I would get to both fixes tonight but I ended up with more time than expected so two releases in close proximity, whoops.. Anyway, mentioning here so that you don't run |
@ava-cassiopeia I tried to use the new version, but it still doesn't seem to work. I get the error I'm not 100% sure what the fix is, but this is a similar library that I'm using that also uses TS and it's working properly: https://github.com/jackocnr/intl-tel-input My best guess without digging further is that you need |
Aw darn, thanks for the hint though! Here's my attempt at a fix: I've just released v0.9.4, please install that and see if it fixes your issue. This version includes the normal minified build file from before (if you're just dropping the file into a webserver) and special compiled-for-nodeJS variants of the code which don't have minification, should be import-able from other code, and as a bonus also include TS declaration files. To produce these, I used compiler settings very similar to the ones in intl-tel-input, so I'm hoping they work correctly. I pointed the |
@ava-cassiopeia It looks like that worked. Thanks! |
Yessss!! Happy to help! |
In
package.json
, themain
entrypoint is listed assrc/javascript/index.js
. However, in the 0.9.0 release, it looks like that was converted to TS.I'm using this package via jspm.io, which requires the file to already be in JS. Can you please add a compilation step to release, so that the published version has the JS file available?
The text was updated successfully, but these errors were encountered: