Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retryIf should be called before onRetry #21

Merged
merged 1 commit into from
Oct 23, 2019
Merged

retryIf should be called before onRetry #21

merged 1 commit into from
Oct 23, 2019

Conversation

pallavJha
Copy link

@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           2        2           
  Lines          70       70           
=======================================
  Hits           68       68           
  Misses          2        2
Impacted Files Coverage Δ
retry.go 95.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 101acd3...639c9f1. Read the comment docs.

@JaSei JaSei merged commit 0554a4a into avast:master Oct 23, 2019
@JaSei
Copy link
Collaborator

JaSei commented Oct 23, 2019

thank you for you PR

JaSei pushed a commit that referenced this pull request Oct 23, 2019
retryIf should be called before onRetry #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The func onRetry should not be called when retryIf returns false
3 participants