Occurrence over night #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f no validation applies, will alter Schedule::Rule, initializing @validations[:month_of_year] with an empty array. Both IceCube and schedule_attributes will benefit for some refactoring of these areas, but this fixes this for now
Upgrade IceCube & Rails4 compatibility
|
My own use-case does not include overnight events so I'm not sure if these semantics would be confusing, but this may be worth rebasing and restricting to only the relevant changes here. See also: #4 |
…cur over night i tried to parse the date to set the end_time-date. But the date doesn't have to exist for endless schedules. Using `parse_date_time` it creates a current date if no date is given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a method which sets the end_time-date one day later than the start_time-date, if @params[:end_time] <= @params[:start_time].
So it is possible to create a schedule over night (e.g. from 8pm to 2 am).