fix(core): make AmplifyOutputs category types as unknown #14153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinkumar6
requested review from
sktimalsina,
cshfang,
HuiSF,
pranavosu and
a team
as code owners
ashwinkumar6
commented
Jan 22, 2025
ashika112
reviewed
Jan 24, 2025
ashwinkumar6
force-pushed
the
amplifyOutputs-deepPartial
branch
from
0d1cbae to
5da2834
Compare
ashwinkumar6
commented
Jan 27, 2025
ashika112
reviewed
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Solves issues where Typescript inferred type from
amplify_outputs.jsonfile is strongly typed when compared to AmplifyOutputs type. Updates AmplifyOutputs type to make all category key's asunknown.Other changes:
AmplifyOutputstype toAmplifyOutputsLegacyand add a deprecating warning.AmplifyOutputstype publicly exposed from "aws-amplify/adapter-core" will exposeAmplifyOutputsLegacyunder the same name instead to avoid any breaking change.LegacyConfigandAmplifyOutputstypes from "aws-amplify/adapter-core"Issue #, if available
A long term solution for issues like #14045, #14106
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.