fix(core): bind this context to browser-based btoa and atob utilities #14180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes a Firefox-specific issue where
atob()
fails when called without proper Window context binding.I received a vague error when trying to invoke the utility method
decodeJWT
inside Firefox:Error: Invalid token payload
. After debugging, I noticed the error was coming from theconvert
method:TypeError: 'atob' called on an object that does not implement interface Window.
Issue #, if available
N/A
Description of how you validated changes
I ran
yarn build
, then used thelink
instructions in the contributing guide to override my project's@aws-amplify/core
dependency to my local, and tested the changes in both Firefox and Chrome. After the changes, the error is no longer thrown in Firefox.decodeJWT
now works in Chrome and Firefox without error.Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.