Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): bind this context to browser-based btoa and atob utilities #14180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dan-lovelace
Copy link

@dan-lovelace dan-lovelace commented Feb 3, 2025

Description of changes

Fixes a Firefox-specific issue where atob() fails when called without proper Window context binding.

I received a vague error when trying to invoke the utility method decodeJWT inside Firefox: Error: Invalid token payload. After debugging, I noticed the error was coming from the convert method:

Screenshot 2025-02-02 at 9 29 11 PM

TypeError: 'atob' called on an object that does not implement interface Window.

Issue #, if available

N/A

Description of how you validated changes

I ran yarn build, then used the link instructions in the contributing guide to override my project's @aws-amplify/core dependency to my local, and tested the changes in both Firefox and Chrome. After the changes, the error is no longer thrown in Firefox. decodeJWT now works in Chrome and Firefox without error.

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant