fix(auth): clear browser tab location before sending final success hub events during OAuth signIn #14188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samaritan1011001
requested review from
sktimalsina,
cshfang,
HuiSF and
pranavosu
as code owners
AllanZhengYP
approved these changes
Feb 5, 2025
HuiSF
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes an issue where we replace the tab location after sending the final hub events disallowing any important app state related actions to take place for sign in hub events (customOAuthState, signInWithRedirect and signIn). By replacing browser state, it marks the final step in the sign in process after which the hub events are dispatched.
Issue #, if available
#13530
Description of how you validated changes
Updated unit tests to verify.
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.