Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ecs): Add support for Container Insights with enhanced observability #32618

Closed
1 of 2 tasks
MPOgbourne opened this issue Dec 20, 2024 · 6 comments · Fixed by #32622
Closed
1 of 2 tasks

(aws-ecs): Add support for Container Insights with enhanced observability #32618

MPOgbourne opened this issue Dec 20, 2024 · 6 comments · Fixed by #32622
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@MPOgbourne
Copy link
Contributor

MPOgbourne commented Dec 20, 2024 •
edited
Loading

Describe the feature

Container Insights with enhanced observability was recently announced and released for ECS. Cloudformation supports setting this at cluster level.

Container Insights with enhanced observability now available in Amazon ECS

Use Case

I'm excited to try out the new observability features, but it's simpler if I can implement the change via the CDK. This is supported via cloudformation.

Proposed Solution

I would propose being able to directly set the container insights level (disabled, enabled, enhanced) on the L2 cluster construct. Ideally, this would be something like new ecs.Cluster(stack, 'EcsCluster', { containerInsights: ContainerInsights.ENHANCED});.
To avoid a breaking change, a new property (containerInsightsLevel?) will be added and the containerInsights property will be marked as deprecated.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.173.2

Environment details (OS name and version, etc.)

Ubuntu 22.04
@MPOgbourne MPOgbourne added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 20, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Dec 20, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 20, 2024
@khushail khushail self-assigned this Dec 20, 2024
@khushail khushail changed the title (ecs): (Add support for Container Insights with enhanced observability) (aws-ecs): Add support for Container Insights with enhanced observability Dec 20, 2024
@khushail
Copy link
Contributor

Hi @MPOgbourne , Looks like Cloudformation L1 construct already has a support for the container insights -https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.CfnCluster.ClusterSettingsProperty.html

Thanks for volunteering for contribution of PR! Team would be happy to review it.

@khushail khushail added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 20, 2024
@khushail khushail removed their assignment Dec 20, 2024
@MPOgbourne MPOgbourne mentioned this issue Dec 21, 2024
Merged
1 task
This was referenced Jan 1, 2025
Closed
Closed
Closed
@BwL1289
Copy link

BwL1289 commented Jan 2, 2025

Is there an ETA on L2 support?

@khushail
Copy link
Contributor

khushail commented Jan 2, 2025 •
edited
Loading

@BwL1289 , there is no ETA on L2 support. Since @MPOgbourne has already submitted this PR, it is just a matter of sometime till PR gets reviewed and merged.

@dannysteenman
Copy link

dannysteenman commented Jan 7, 2025 •
edited
Loading

+1 for L2 support!

@mergify mergify bot closed this as completed in #32622 Jan 12, 2025
@mergify mergify bot closed this as completed in 79ab137 Jan 12, 2025
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
iankhou pushed a commit that referenced this issue Jan 13, 2025
@MPOgbourne
feat(ecs): enable Enhanced Observability for Container Insights (#32622)
b2c7974 
### Issue # (if applicable)

Closes #32618.

### Reason for this change


Container Insights with enhanced observability was recently announced and released for ECS. Cloudformation and the L1 CFN construct support setting this at cluster level. This adds the Container Insights with enhanced observability as an option for the existing L2 Cluster construct. 

### Description of changes


ENHANCED was added to the ContainerInsights enum. A new containerInsightsV2 property was added to the Cluster construct with the type ContainerInsights. The existing containerInsights property was marked as deprecated.


### Description of how you validated changes


Unit and Integration tests were added.

### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): enable Enhanced Observability for Container Insights MPOgbourne/aws-cdk
4 participants
@dannysteenman @BwL1289 @MPOgbourne @khushail