Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-location: Map, PlaceIndex and RouteCalculator constructs should be marked as legacy #32722

Closed
1 of 2 tasks
mazyu36 opened this issue Jan 3, 2025 · 4 comments · Fixed by #32871
Closed
1 of 2 tasks

aws-location: Map, PlaceIndex and RouteCalculator constructs should be marked as legacy #32722

mazyu36 opened this issue Jan 3, 2025 · 4 comments · Fixed by #32871
Labels
@aws-cdk/aws-location-alpha Related to the @aws-cdk/aws-location-alpha package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Jan 3, 2025 •
edited
Loading

Describe the feature

Amazon Location Service launches Enhanced Places, Routes, and Maps on Nov 8, 2024 (Ref).

New APIs for Maps, Places and Routes are launched and account-bound resources are no longer required.
This is noted in the management console's feature spotlight.
image

Therefore Map, PlaceIndex and RouteCalculator constructs are now considered legacy.
I suggest marking these constructs as legacy in the docs.

Use Case

When use new Amazon Location APIs.

Proposed Solution

Add a note in the docs that these constructs are legacy.

Other Information

https://aws.amazon.com/blogs/aws/announcing-new-apis-for-amazon-location-service-routes-places-and-maps/

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.173.4

Environment details (OS name and version, etc.)

All
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 3, 2025
@github-actions github-actions bot added the @aws-cdk/aws-location-alpha Related to the @aws-cdk/aws-location-alpha package label Jan 3, 2025
@ashishdhingra ashishdhingra self-assigned this Jan 3, 2025
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 3, 2025
@ashishdhingra
Copy link
Contributor

ashishdhingra commented Jan 3, 2025 •
edited
Loading

Unsure if there is separated resource specification for new enhanced Places, Routes, and Maps (these are not available as separated resources via CloudFormation or schema as of now). If these would be available as separate resources, we should mark existing ones as legacy.

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jan 3, 2025
@ashishdhingra ashishdhingra removed their assignment Jan 3, 2025
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jan 4, 2025

Thank you for the reply.
The new enhanced Places, Routes, and Maps utilize AWS-managed resources, eliminating the need for users to create resources themselves.
Therefore, no separated resources exist.

image

Given this, there is currently no need to use the constructs related to Places, Routes, and Maps.
However, I suggest we keep these constructs for backward compatibility and propose documenting them as legacy in the docs.

@mazyu36 mazyu36 mentioned this issue Jan 13, 2025
Merged
1 task
@mergify mergify bot closed this as completed in #32871 Jan 28, 2025
@mergify mergify bot closed this as completed in 69b25da Jan 28, 2025
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2025
mazyu36 added a commit to mazyu36/aws-cdk that referenced this issue Jan 28, 2025
@mazyu36
docs(location): specify that Map, PlaceIndex, and RouteCalculator are…
aa0019d 
… now legacy in README (aws#32871)

Closes aws#32722.

Amazon Location Service launches Enhanced Places, Routes, and Maps on Nov 8, 2024 ([Ref](https://aws.amazon.com/about-aws/whats-new/2024/11/amazon-location-service-enhanced-places-routes-maps/?nc1=h_ls)).

New APIs for Maps, Places and Routes are launched and account-bound resources are no longer required.

Therefore, I think it’s better to mention in the README that the constructs related to these are considered legacy.

* Add a section for legacy resources in the README.
* Move the descriptions related to Map, PlaceIndex, and RouteCalculator to that section.

None

None

- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 added a commit to mazyu36/aws-cdk that referenced this issue Jan 28, 2025
@mazyu36
docs(location): specify that Map, PlaceIndex, and RouteCalculator are…
a732d5f 
… now legacy in README (aws#32871)

Closes aws#32722.

Amazon Location Service launches Enhanced Places, Routes, and Maps on Nov 8, 2024 ([Ref](https://aws.amazon.com/about-aws/whats-new/2024/11/amazon-location-service-enhanced-places-routes-maps/?nc1=h_ls)).

New APIs for Maps, Places and Routes are launched and account-bound resources are no longer required.

Therefore, I think it’s better to mention in the README that the constructs related to these are considered legacy.

* Add a section for legacy resources in the README.
* Move the descriptions related to Map, PlaceIndex, and RouteCalculator to that section.

None

None

- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-location-alpha Related to the @aws-cdk/aws-location-alpha package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@mazyu36 @ashishdhingra