Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pkglint): uncomment pkglint functionality #28622

Merged
merged 1 commit into from
Jan 9, 2024
Merged

chore(pkglint): uncomment pkglint functionality #28622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk/THIRD_PARTY_LICENSES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI

----------------

** cdk-from-cfn@0.91.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.91.0 | MIT OR Apache-2.0
** cdk-from-cfn@0.113.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.113.0 | MIT OR Apache-2.0

----------------

Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,4 @@
"publishConfig": {
"tag": "latest"
}
}
}
2 changes: 1 addition & 1 deletion tools/@aws-cdk/cdk-build-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,4 @@
"ubergen": {
"exclude": true
}
}
}
4 changes: 1 addition & 3 deletions tools/@aws-cdk/pkglint/bin/pkglint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env node
import * as path from 'path';
import * as yargs from 'yargs';
//import { findPackageJsons, ValidationRule } from '../lib';
import { findPackageJsons, ValidationRule } from '../lib';

const argv = yargs
.env('PKGLINT_')
Expand All @@ -19,7 +19,6 @@ if (typeof(directory) !== 'string') {
argv.directory = path.resolve(directory, process.cwd());

async function main(): Promise<void> {
/*
const ruleClasses = require('../lib/rules'); // eslint-disable-line @typescript-eslint/no-require-imports
const rules: ValidationRule[] = Object.keys(ruleClasses).map(key => new ruleClasses[key]()).filter(obj => obj instanceof ValidationRule);

Expand All @@ -37,7 +36,6 @@ async function main(): Promise<void> {
if (pkgs.some(p => p.hasReports)) {
throw new Error('Some package.json files had errors');
}
*/
}

main().catch((e) => {
Expand Down
Loading