Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools): update README for spec2cdk with an example #31935

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

iph
Copy link
Contributor

@iph iph commented Oct 29, 2024

Without an example, it feels very difficult to use spec2cdk as you need a --service in order for the tool to pick up the temporary-schemas.

Issue # (if applicable)

Not applicable

Reason for this change

Just a usability clarification.

Description of changes

I've updated only the README

Description of how you validated changes

I read the changes in preview for markdown.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Without an example, it feels very difficult to use spec2cdk as you need a `--service` in order for the tool to pick up the temporary-schemas.
@aws-cdk-automation aws-cdk-automation requested a review from a team October 29, 2024 16:40
@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Oct 29, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@iph iph changed the title chore(tools): Update README for spec2cdk with an example chore(tools): update README for spec2cdk with an example Oct 29, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 29, 2024 16:53

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain
Copy link
Contributor

mrgrain commented Oct 30, 2024

@mergify update

Copy link
Contributor

mergify bot commented Oct 30, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 311e21e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Oct 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 33a4a5d into aws:main Oct 30, 2024
9 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants