Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(synthetics): runtime puppeteer 9_1 #32026

Merged
merged 5 commits into from
Nov 6, 2024
Merged

chore(synthetics): runtime puppeteer 9_1 #32026

merged 5 commits into from
Nov 6, 2024

Conversation

kaiz-io
Copy link
Contributor

@kaiz-io kaiz-io commented Nov 5, 2024 •
edited
Loading

Issue # (if applicable)

No issue

Reason for this change

There is a new runtime that was published. syn-nodejs-puppeteer-9.1

Description of changes

Just adding the new runtime.

Description of how you validated changes

Against documentation and updating that the template deploys with the new runtime version.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 5, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 5, 2024 14:43
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 5, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kaiz-io kaiz-io changed the title Feat(synthetics): Add new runtime puppeteer 9.1 feat(synthetics): Add new runtime puppeteer 9.1 Nov 5, 2024
@kaiz-io kaiz-io changed the title feat(synthetics): Add new runtime puppeteer 9.1 chore(synthetics): Add new runtime puppeteer 9.1 Nov 5, 2024
@kaiz-io
Copy link
Contributor Author

kaiz-io commented Nov 5, 2024

Clarification Request

@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 5, 2024
@kaiz-io kaiz-io changed the title chore(synthetics): Add new runtime puppeteer 9.1 chore(synthetics): Add new runtime puppeteer 9_1 Nov 5, 2024
@kaizencc kaizencc changed the title chore(synthetics): Add new runtime puppeteer 9_1 feat(synthetics): runtime puppeteer 9_1 Nov 5, 2024
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run labels Nov 5, 2024
kaizencc
kaizencc previously approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 5, 2024 16:22

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed kaizencc’s stale review November 5, 2024 16:45

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 5, 2024
moelasmar
moelasmar previously approved these changes Nov 6, 2024
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 6, 2024
@moelasmar moelasmar changed the title feat(synthetics): runtime puppeteer 9_1 chore(synthetics): runtime puppeteer 9_1 Nov 6, 2024
@moelasmar moelasmar removed pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Nov 6, 2024
@moelasmar moelasmar removed the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed moelasmar’s stale review November 6, 2024 08:10

Pull request has been modified.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6d37cd0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 80ddefb into aws:main Nov 6, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moelasmar moelasmar moelasmar approved these changes

@kaizencc kaizencc kaizencc left review comments

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiz-io @aws-cdk-automation @kaizencc @moelasmar