chore(scheduler-alpha-targets): raise awareness for default policy risk #33003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samson-keung
commented
Jan 17, 2025
samson-keung
commented
Jan 17, 2025
packages/@aws-cdk/aws-scheduler-targets-alpha/test/universal.test.ts
Outdated
Show resolved
Hide resolved
gracelu0
reviewed
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33003 +/- ##
=======================================
Coverage 81.46% 81.46%
=======================================
Files 225 225
Lines 13750 13750
Branches 2412 2412
=======================================
Hits 11202 11202
Misses 2273 2273
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Grace Luo <[email protected]>
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
@Mergifyio update |
✅ Branch has been successfully updated |
gracelu0
approved these changes
Jan 20, 2025
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A.
Reason for this change
Raise awareness on the
*used for resources in the default policy in theUniversaltarget class.Description of changes
README updates and added a new warning.
Describe any new or updated permissions being added
None
Description of how you validated changes
Unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license