Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix(custom-resource): provider framework lambda missing GetFunction permission #33156

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

moelasmar
Copy link
Contributor

@moelasmar moelasmar commented Jan 24, 2025

This reverts PR #32904

This reverts commit 035d17d.

@aws-cdk-automation aws-cdk-automation requested a review from a team January 24, 2025 19:44
@github-actions github-actions bot added the p2 label Jan 24, 2025
@moelasmar moelasmar changed the title revert: fix(custom-resource): provider framework lambda missing GetFunction permission #32904 revert: fix(custom-resource): provider framework lambda missing GetFunction permission Jan 24, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 24, 2025
Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the branch to verify the code look to be the same as before the commit. I.e. the revert is reverting the correct code.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.77%. Comparing base (69a8729) to head (7cd4ac9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33156   +/-   ##
=======================================
  Coverage   80.77%   80.77%           
=======================================
  Files         232      232           
  Lines       14110    14110           
  Branches     2453     2453           
=======================================
  Hits        11398    11398           
  Misses       2432     2432           
  Partials      280      280           
Flag Coverage Δ
suite.unit 80.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.50% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

Copy link
Contributor

mergify bot commented Jan 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7cd4ac9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 03be84f into main Jan 24, 2025
20 checks passed
@mergify mergify bot deleted the revert-32904-custom-resource-missing-permission branch January 24, 2025 21:34
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants