feat(cognito): Add support for standard & custom attributes

[netroy]

Fixes #1747 & #5866

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[nija-at]

Can this wait a couple of weeks? I'm working on (re-)designing the CDK Cognito APIs and would like to align this with that work.

It looks like this isn't a blocking issue and users have a way to work around this.

We should decouple the 'timezone' change into a separate PR with the title fix and an appropriate message.

[netroy]

Absolutely.
I'm using the Cfn* constructs directly in my current project, so not blocked by this.
If you prefer, I can also close this PR, & revisit after your changes.

[nija-at]

Leave it open for now. We'll take a call once I have more data.

[nija-at]

My proposal to re-work Cognito's APIs is here - aws/aws-cdk-rfcs#91. The RFC is in the comments period. Feel free to chime in if you have any comments on the proposal.

Closing this issue in favour of this. The implementation of this RFC will address user pool attributes.

[netroy]

@nija-at should i send a bug-fix PR with only the second commit?

[nija-at]

I went ahead and already did this - acf3ffc. Hope you don't mind.

[netroy]

Thanks, you saved me some time. Why would I mind 😅.