-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(batch): include breaking change in previous PR #6621
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that work? Wouldn’t the change log generator ignore this since it’s a “chore”?
@eladb From the conventional commits spec:
Should work... |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
BREAKING CHANGE: the `allocationStrategy` property was moved from `ComputeEnvironmentProps` to the `ComputeResources` interface, which is where it semantically belongs.
BREAKING CHANGE: the `allocationStrategy` property was moved from `ComputeEnvironmentProps` to the `ComputeResources` interface, which is where it semantically belongs.
This is a "dummy" PR so that our next release will include the breaking change notice from this, previous PR: #6549
The reason it wasn't picked up in the original PR is because mergify takes the content between
## Commit Message
and the next markdown header, and i didn't notice the breaking change notice falls outside of the proper section.Since this PR is a chore, it won't end up in the release notes except from the breaking change notice, which, according to conventional commits, is respected with any commit type
Commit Message
chore(batch): include breaking change in previous PR (#6621)
BREAKING CHANGE: the
allocationStrategy
property was moved fromComputeEnvironmentProps
to theComputeResources
interface, which is where it semantically belongs.End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license