Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(batch): include breaking change in previous PR #6621

Merged
merged 2 commits into from
Mar 8, 2020

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Mar 8, 2020

This is a "dummy" PR so that our next release will include the breaking change notice from this, previous PR: #6549

The reason it wasn't picked up in the original PR is because mergify takes the content between ## Commit Message and the next markdown header, and i didn't notice the breaking change notice falls outside of the proper section.

Since this PR is a chore, it won't end up in the release notes except from the breaking change notice, which, according to conventional commits, is respected with any commit type

Commit Message

chore(batch): include breaking change in previous PR (#6621)

BREAKING CHANGE: the allocationStrategy property was moved from ComputeEnvironmentProps to the ComputeResources interface, which is where it semantically belongs.

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 8, 2020
@iliapolo iliapolo requested a review from a team March 8, 2020 07:00
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e8596d3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that work? Wouldn’t the change log generator ignore this since it’s a “chore”?

@iliapolo
Copy link
Contributor Author

iliapolo commented Mar 8, 2020

@eladb From the conventional commits spec:

BREAKING CHANGE: a commit that has the text BREAKING CHANGE: at the beginning of its optional body or footer section introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type.

Should work...

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d17926d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a5c9d4e into master Mar 8, 2020
@mergify mergify bot deleted the epolon/batch-breaking-change branch March 8, 2020 09:54
eladb pushed a commit that referenced this pull request Mar 9, 2020
BREAKING CHANGE: the `allocationStrategy` property was moved from `ComputeEnvironmentProps` to the `ComputeResources` interface, which is where it semantically belongs.
horsmand pushed a commit to horsmand/aws-cdk that referenced this pull request Mar 9, 2020
BREAKING CHANGE: the `allocationStrategy` property was moved from `ComputeEnvironmentProps` to the `ComputeResources` interface, which is where it semantically belongs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants