Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(custom-resources): log retention for AwsCustomResource #6677

Merged
merged 5 commits into from
Mar 12, 2020
Merged

feat(custom-resources): log retention for AwsCustomResource #6677

merged 5 commits into from
Mar 12, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Mar 11, 2020 •
edited
Loading

Description

Add a logRetention prop to AwsCustomResourceProps to specify a custom log retention.

Commit Message

feat(custom-resources): log retention for AwsCustomResource (#6677)

Add a logRetention prop to AwsCustomResourceProps to specify a custom log retention.

Closes #6652

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

jogold added 2 commits March 11, 2020 16:25
@jogold
feat(custom-resources): log retention for AwsCustomResource
1dddb7d 
Add a `logRetention` prop to `AwsCustomResourceProps` to specify a custom log retention.

Closes aws#6652
@jogold
README
f73a3ad
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1dddb7d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f73a3ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8e56e83
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fbb492c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 71201db
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2203ec2 into aws:master Mar 12, 2020
@iliapolo iliapolo mentioned this pull request Mar 12, 2020
Merged
@jogold jogold deleted the aws-custom-resource-log-retention branch April 27, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AwsCustomResource support for log retention
3 participants
@jogold @aws-cdk-automation @eladb