Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): show output during asset bundling #8975

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jul 9, 2020

Show Docker output during asset bundling.

Closes #8956


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Show Docker outpout during asset bundling.

Closes aws#8956
@jogold jogold changed the title feat(core): show output during asset bundling chore(core): show output during asset bundling Jul 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5e03811
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2386faa into aws:master Jul 10, 2020
@jogold jogold deleted the bundling-log branch July 10, 2020 05:45
@bl-ue
Copy link
Contributor

bl-ue commented Jul 11, 2021

What happened to this? It doesn't seem to be working for me, with aws-s3-deployment and cdk 1.112 🤔

@jogold
Copy link
Contributor Author

jogold commented Jul 12, 2021

What happened to this? It doesn't seem to be working for me, with aws-s3-deployment and cdk 1.112 🤔

This PR is about showing Docker output during bundling. aws-s3-deployment doesn't use bundling by default but if you use BucketDeployment with an asset that uses bundling the output should be shown. If not, please open an new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Show Docker build output for assets
4 participants