feat(ec2): CloudFormation init for files, packages, sources, users, & groups #9664
Conversation
…nd groups Cloudformation Init (cfn-init) support was introduced in #9065 with a minimal set of support for various init element types. This PR is a continuation of that support (based on the original #8788), and adds the remaining init element types: files, packages, sources, users, and groups. With this PR, CloudFormation init support for EC2 instances is complete. A final PR will be submitted to extend this support to auto-scaling groups (again, based on the original work done in #8788).
| ]), | ||
| config: new ec2.InitConfig([ | ||
| // Create a JSON file from tokens (can also create other files) | ||
| ec2.InitFile.fromObject('/etc/stack.json', { |
There was a problem hiding this comment.
Reading this I'm regretting this not being ec2.InitElement.fileFromObject(...).
Although even reading that I'm not sure it would be better. Augh!
There was a problem hiding this comment.
Nothing like 6 weeks without seeing a piece of code to bring a new perspective (although not necessarily enlightenment). :D
Introduces CloudFormation init (cfn-init) support for autoscaling groups. This builds on the previous work (#9065) and (#9664) that introduced init support for instances. This change also reworks the existing signaling functionality, as this becomes even more important with cfn-init. A final change was to adjust the (internal) interface of the `_attach` method to accept an `ec2.OperatingSystemType` instead of the internal-only `ec2.InitPlatform` type which wasn't exported and unavailable within the asg module. This change is also in the #9664 diff, as both are pending. Credit for 90% of this goes to @rix0rrr; all cfn-init support was pair- programmed, but the ASG stuff was much more heavily done by him.
Will remove the label on Monday unless there are further comments. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Introduces CloudFormation init (cfn-init) support for autoscaling groups. This builds on the previous work (#9065) and (#9664) that introduced init support for instances. This change also reworks the existing signaling functionality, as this becomes even more important with cfn-init. A final change is to export the `CloudFormationInit._attach` method and related options. Credit for 90% of this goes to @rix0rrr; all cfn-init support was pair- programmed, but the ASG stuff was mostly him. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Cloudformation Init (cfn-init) support was introduced in #9065 with a minimal
set of support for various init element types. This PR is a continuation of
that support (based on the original #8788), and adds the remaining init element
types: files, packages, sources, users, and groups.
With this PR, CloudFormation init support for EC2 instances is complete. A final
PR will be submitted to extend this support to auto-scaling groups (again, based
on the original work done in #8788).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license