Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubetest2/eksapi): Fix 'unmanaged-nodegroup-efa.yaml' by removing references to SSHKeyPair #532

Merged
merged 2 commits into from
Dec 24, 2024
Merged

fix(kubetest2/eksapi): Fix 'unmanaged-nodegroup-efa.yaml' by removing references to SSHKeyPair #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fea1da
Fix 'unmanaged-nodegroup-efa.yaml' by removing references to SSHKeyPair
mattcjo Dec 24, 2024
4e1fc18
Delete /_artifacts and /_rundir directories and add to '.gitignore'
mattcjo Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@
/aws-k8s-tester
*/*/.DS_Store
*/.DS_Store
/_artifacts
/_rundir
26 changes: 0 additions & 26 deletions kubetest2/internal/deployers/eksapi/templates/unmanaged-nodegroup-efa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ Parameters:
Description: The IAM role name of worker nodes.
Type: String

SSHKeyPair:
Type: String

UserData:
Type: String

Expand Down Expand Up @@ -120,28 +117,6 @@ Resources:
GroupId: !Ref EFASecurityGroup
IpProtocol: "-1"

EFASecurityGroupIngressSSHIpv4:
Type: "AWS::EC2::SecurityGroupIngress"
DependsOn: EFASecurityGroup
Properties:
Description: Allow SSH
FromPort: 22
ToPort: 22
CidrIp: "0.0.0.0/0"
GroupId: !Ref EFASecurityGroup
IpProtocol: "tcp"

EFASecurityGroupIngressSSHIpv6:
Type: "AWS::EC2::SecurityGroupIngress"
DependsOn: EFASecurityGroup
Properties:
Description: Allow SSH
FromPort: 22
ToPort: 22
CidrIpv6: "::/0"
GroupId: !Ref EFASecurityGroup
IpProtocol: "tcp"

EFASecurityGroupIngressControlPlane:
Type: "AWS::EC2::SecurityGroupIngress"
DependsOn: EFASecurityGroup
Expand Down Expand Up @@ -225,7 +200,6 @@ Resources:
Arn: !GetAtt NodeInstanceProfile.Arn
ImageId: !Ref AMIId
InstanceType: !Ref InstanceType
KeyName: !Ref SSHKeyPair
NetworkInterfaces:
Fn::If:
- IsP5Node
Expand Down
Loading