Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job type check #557

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix job type check #557

merged 1 commit into from
Jan 10, 2025

Conversation

cartermckinnon
Copy link
Member

@cartermckinnon cartermckinnon commented Jan 10, 2025

Description of changes:

The check for Kind is not effective, we need to revert to the previous impl, but use the MPIJobFacade.

switch job.(type) {
case *kubeflowv2beta1.MPIJob:
jobLabel = fmt.Sprintf("job-name=%s-launcher", job.GetName())
case *batchv1.Job:
jobLabel = fmt.Sprintf("job-name=%s", job.GetName())
default:
return "", fmt.Errorf("unsupported job type %T", job)
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cartermckinnon cartermckinnon merged commit eed33db into main Jan 10, 2025
7 checks passed
@cartermckinnon cartermckinnon deleted the job-type branch January 10, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants