Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type-safe-api): fix reversed pydantic minimum and maximum #908

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

jstrunk
Copy link
Contributor

@jstrunk jstrunk commented Feb 19, 2025

Correct the generated Pydantic fields so that minimum is greater than and maximum is less than.

fix #907

Correct the generated Pydantic fields so that `minimum` is greater than and `maximum` is less than.

fix aws#907
Copy link
Member

@cogwirrel cogwirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

Copy link

nx-cloud bot commented Feb 19, 2025

View your CI Pipeline Execution ↗ for commit d7ce335.

Command Status Duration Result
nx run-many --target=build --output-style=strea... ✅ Succeeded 12m 57s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-19 20:23:17 UTC

@cogwirrel cogwirrel merged commit e1250a4 into aws:mainline Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] (type-safe-api): generated python swaps greater than and less than
2 participants