-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(middleware-endpoint-discovery): add middleware for Endpoint Discovery #2369
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2369 +/- ##
=======================================
Coverage ? 59.09%
=======================================
Files ? 490
Lines ? 26160
Branches ? 6201
=======================================
Hits ? 15460
Misses ? 10700
Partials ? 0 Continue to review full report at Codecov.
|
cd4c95c
to
2977be8
Compare
50793d7
to
56cf83c
Compare
packages/middleware-endpoint-discovery/src/resolveEndpointDiscoveryConfig.ts
Show resolved
Hide resolved
packages/middleware-endpoint-discovery/src/resolveEndpointDiscoveryConfig.ts
Outdated
Show resolved
Hide resolved
packages/middleware-endpoint-discovery/src/endpointDiscoveryMiddleware.ts
Outdated
Show resolved
Hide resolved
packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.ts
Outdated
Show resolved
Hide resolved
packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.ts
Outdated
Show resolved
Hide resolved
packages/middleware-endpoint-discovery/src/getEndpointDiscoveryPlugin.ts
Outdated
Show resolved
Hide resolved
packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Approving it with minor doc feedbacks.
packages/middleware-endpoint-discovery/src/resolveEndpointDiscoveryConfig.ts
Show resolved
Hide resolved
packages/middleware-endpoint-discovery/src/resolveEndpointDiscoveryConfig.ts
Show resolved
Hide resolved
packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.ts
Show resolved
Hide resolved
Co-authored-by: AllanZhengYP <[email protected]>
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Refs: #2211
Description
Adds middleware for Endpoint Discovery.
The base branch for this PR would be changed tomain
after #2355 is merged.Testing
Unit tests added.
Testing also done with PoC code in #2339
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.