Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-s3): fix union serialization #1730

Merged
merged 2 commits into from
Nov 30, 2020
Merged

fix(client-s3): fix union serialization #1730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bf2539
chore: fix serializing unions in XML
AllanZhengYP Nov 30, 2020
709daa3
fix(client-s3): fix union serialization
AllanZhengYP Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions clients/client-s3/protocols/Aws_restXml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10152,7 +10152,7 @@ const serializeAws_restXmlAnalyticsFilter = (input: AnalyticsFilter, context: __
if (!(value instanceof __XmlNode || value instanceof __XmlText)) {
throw new Error("Unable to serialize unknown union members in XML.");
}
bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));
bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));
},
});
return bodyNode;
Expand Down Expand Up @@ -11022,7 +11022,7 @@ const serializeAws_restXmlLifecycleRuleFilter = (input: LifecycleRuleFilter, con
if (!(value instanceof __XmlNode || value instanceof __XmlText)) {
throw new Error("Unable to serialize unknown union members in XML.");
}
bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));
bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));
},
});
return bodyNode;
Expand Down Expand Up @@ -11130,7 +11130,7 @@ const serializeAws_restXmlMetricsFilter = (input: MetricsFilter, context: __Serd
if (!(value instanceof __XmlNode || value instanceof __XmlText)) {
throw new Error("Unable to serialize unknown union members in XML.");
}
bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));
bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));
},
});
return bodyNode;
Expand Down Expand Up @@ -11572,7 +11572,7 @@ const serializeAws_restXmlReplicationRuleFilter = (input: ReplicationRuleFilter,
if (!(value instanceof __XmlNode || value instanceof __XmlText)) {
throw new Error("Unable to serialize unknown union members in XML.");
}
bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));
bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));
},
});
return bodyNode;
Expand Down
2 changes: 1 addition & 1 deletion ...degen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeSerVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ protected void serializeUnion(GenerationContext context, UnionShape shape) {
});

// Set the node explicitly for potentially correct cases.
writer.write("bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));");
writer.write("bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));");
});
});

Expand Down