Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2298

Closed
wants to merge 1 commit into from
Closed

Update README.md #2298

wants to merge 1 commit into from

Conversation

LipiLee
Copy link
Contributor

@LipiLee LipiLee commented Apr 23, 2021

Fix a typo

Issue

Issue number, if available, prefixed with "#"

Description

What does this implement/fix? Explain your changes.

Testing

How was this change tested?

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fix a typo
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@e3772e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2298   +/-   ##
=======================================
  Coverage        ?   59.99%           
=======================================
  Files           ?      470           
  Lines           ?    24749           
  Branches        ?     5862           
=======================================
  Hits            ?    14847           
  Misses          ?     9902           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3772e0...d5215b7. Read the comment docs.

@trivikr
Copy link
Member

trivikr commented Apr 28, 2021

Thank you @LipiLee for your PR.
The fix needs to be done in CodeGen to be applicable for all clients.

I've cherry-picked your commit and posted new PR at #2314

@trivikr trivikr closed this Apr 28, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
@LipiLee LipiLee deleted the patch-1 branch May 13, 2021 04:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants