Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cast for size_t while logging #200

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Add cast for size_t while logging #200

merged 5 commits into from
Mar 23, 2021

Conversation

pvyawaha
Copy link
Contributor

Issue #, if available: #199

Description of changes:
This change adds a cast when logging size_t type .

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pvyawaha pvyawaha changed the title Add cast for size_t Add cast for size_t while logging Mar 18, 2021
@ser90368141
Copy link
Contributor

Hi pvyawaha!
Please add casting in these two places.

LogError( ( "Insufficient user memory: "
"[key: valueLength]=[%s: %lu]",
pKey,
valueLength ) );

LogDebug( ( "Failed to parse custom job document: OtaJobParseErr_t=%s, jobIdLength=%lu",
OTA_JobParse_strerror( jobDoc.parseErr ), jobDoc.jobIdLength ) );

I added these changes and the library built successfully.
Thank!

@pvyawaha pvyawaha requested a review from divekarshubham March 19, 2021 17:45
yanjos-dev
yanjos-dev previously approved these changes Mar 22, 2021
divekarshubham
divekarshubham previously approved these changes Mar 23, 2021
Copy link
Contributor

@gkwicker gkwicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@gkwicker gkwicker merged commit a179459 into main Mar 23, 2021
@pvyawaha pvyawaha deleted the size_t_cast_logs branch March 24, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants