Feature: Add user callable agent cycler #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dachalco
force-pushed
the
feat-ota-process
branch
from
9e7f7ac to
7e83fff
Compare
dachalco
force-pushed
the
feat-ota-process
branch
2 times, most recently
from
3852291 to
8cd029b
Compare
ravibhagavandas
approved these changes
Jun 18, 2022
cobusve
approved these changes
Jun 20, 2022
dachalco
force-pushed
the
feat-ota-process
branch
from
3698eed to
f1f50c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some users may not want to spawn a new thread just to run ota agent. To accommodate, a single-cycle function has been added that effectively runs a single iteration of the loop in
OTA_EventProcessingTask.Currently
OtaAgentStateReadyis used by the library to know when the ota processor task has started. This notion of task readiness is retained with the new function, where the agent is notOtaAgentStateReadyuntil theOTA_EventProcesshas been called for the first time in it's new, user defined, daemon.State is returned from
OTA_EventProcessas a potential for users to react to, or perhaps log, the ota agent state uponOTA_EventProcessreturn.Caveats
Unfortunately, the library does not provide thread sync mechanisms in its PAL OSAL, so using both
OTA_EventProcessandOTA_EventProcessingTaskin an application is not thread safe. Perhaps an OTA user config should be added to make the two mutually exclusive in builds?Checklist:
I have read and applied the rules stated in CONTRIBUTING.md.n/a No such file.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.