Misra Compliance Updates #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the removal of assert for when doing coverity_analysis builds. Made some cast changes to remove warnings. Fixed some type casting issues. Then updated MISRA.md and misra.config files.
Going to try out casting the 0xFFU to a uint8_t before the and, otherwise I'll do a mask variable.
non-100% line check. Then another change to getFileContextFromJob() to attempt to please MISRA and our PR checks.
… on complexity, so this is potentially the most MISRA compliant we can get the function
Modified some variables consts to help with MISRA violations. Updated MISRA.md file to use the new format. Updated inline suppression to use new format. Removed a problematic ENUM and now using #define'd values.
so removing that const and adding in an inline supression.
…AllowDowngrade message, then a seperate one for if it's being done with the versionCheck
ravibhagavandas
previously approved these changes
Aug 15, 2022
source/ota.c
Outdated
| @@ -1014,6 +1017,9 @@ static OtaErr_t processJobHandler( const OtaEventData_t * pEventData ) | |||
| } | |||
|
|
|||
| /* Application callback for event processed. */ | |||
| /* MISRA Ref 11.8.1 [Function pointer and use of const pointer] */ | |||
There was a problem hiding this comment.
Is this comment ([Function pointer and use of const pointer]) correct? I am not sure where is the function pointer.
source/ota.c
Outdated
| @@ -1285,6 +1294,9 @@ static OtaErr_t processDataHandler( const OtaEventData_t * pEventData ) | |||
| } | |||
|
|
|||
| /* Application callback for event processed. */ | |||
| /* MISRA Ref 11.8.1 [Function pointer and use of const pointer] */ | |||
| */ | ||
| LogInfo( ( "Image version is valid: Begin testing file: File ID=%d", | ||
| otaAgent.serverFileID ) ); | ||
| #if ( otaconfigAllowDowngrade == 1U ) |
There was a problem hiding this comment.
Do we not need the condition || ( errVersionCheck == OtaErrNone ) ) here?
added 3 commits
August 19, 2022 20:23
…etting used and as such are no longer being flagged
ravibhagavandas
previously approved these changes
Aug 20, 2022
… the misra.config file
AniruddhaKanhere
approved these changes
Aug 24, 2022
ravibhagavandas
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the codebase to remove MISRA violations
Description
In summary, this is a mix of casting changes as well as variable swaps to remove MISRA violations. Violations that were not feasible to be removed have had inline suppression, with justification, added to them. There are still a few violations that need to be fixed, but this is the vast majority of them.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.