feat: make AppSync::DataSource mappings (DynamoDB) #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradrx
changed the title
aaythapa
reviewed
Feb 14, 2023
hoffa
reviewed
Feb 14, 2023
GavinZZ
reviewed
Feb 14, 2023
ssenchenko
reviewed
Feb 14, 2023
aaythapa
reviewed
Feb 14, 2023
hoffa
reviewed
Feb 14, 2023
hoffa
reviewed
Feb 15, 2023
hoffa
reviewed
Feb 15, 2023
ssenchenko
reviewed
Feb 15, 2023
aaythapa
reviewed
Feb 15, 2023
aaythapa
approved these changes
Feb 16, 2023
hoffa
reviewed
Feb 16, 2023
ssenchenko
approved these changes
Feb 16, 2023
hoffa
approved these changes
Feb 16, 2023
GavinZZ
pushed a commit
to GavinZZ/serverless-application-model
that referenced
this pull request
Mar 2, 2023
Disregarding failed backward compatibility check as the deleted functionality wasn't ever released
GavinZZ
pushed a commit
to GavinZZ/serverless-application-model
that referenced
this pull request
Mar 2, 2023
Disregarding failed backward compatibility check as the deleted functionality wasn't ever released
GavinZZ
pushed a commit
to GavinZZ/serverless-application-model
that referenced
this pull request
Mar 2, 2023
Disregarding failed backward compatibility check as the deleted functionality wasn't ever released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
Created new resource
Serverless::GraphQLDataSource.The properties map to the
AppSync::DataSourceresource in CFN.DynamoDB is the only supported datasource with more to be added later.
I will be adding the connector changes in a follow up PR once we add
AppSync::DataSourceto connector profiles.Description of how you validated changes
Created schema changes and ran against new transform tests.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.