build(nvidia): support arm64 builds #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbaker1
commented
Feb 5, 2025
Comment on lines
+57
to
+58
| # update all current .repo sources to enable gpgcheck | ||
| sudo dnf config-manager --save --setopt=*.gpgcheck=1 |
There was a problem hiding this comment.
i think this api is cleaner than using sed
Issacwww
reviewed
Feb 13, 2025
| @@ -32,6 +32,7 @@ | |||
| | `launch_block_device_mappings_volume_size` | | | |||
| | `nodeadm_build_image` | Image to use as a build environment for nodeadm | | |||
| | `nvidia_driver_major_version` | To be used only when ```enable_accelerator = nvidia```. Driver version to install, depends on what is available in NVIDIA repository. | | |||
| | `nvidia_repository_url` | YUM/DNF Repository override for the NVIDIA driver packages | | |||
There was a problem hiding this comment.
what is the use case for override?
There was a problem hiding this comment.
changing the source packages like you see in the overview, which could also be a private target
Issacwww
approved these changes
Feb 13, 2025
|
Was this reviewed before merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
this PR removes
x86_64specific packages in the nvidia driver provisioner and an override for the repository source URL as an env-template.also adds
g5gto the list of supported GPU instance type families innodeadm.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
make \ k8s=1.31 \ arch=arm64 \ os_distro=al2023 \ enable_accelerator=nvidia \ nvidia_repository_url='https://developer.download.nvidia.com/compute/cuda/repos/rhel9/sbsa/cuda-rhel9.repo'See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.